Migrated TextField tests to @testing-library/react
#1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 231 231
Lines 3821 3821
Branches 1029 1029
=======================================
Hits 3615 3615
Misses 82 82
Partials 124 124 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
Theme: Material-UI
github-actions
bot
added
Theme: Bootstrap 4
kestarumper
requested review from
a team,
zaxovaiko,
zendranm and
piotrpospiech
and removed request for
a team
piotrpospiech
previously approved these changes
Feb 22, 2024
zaxovaiko
previously approved these changes
Feb 22, 2024
kestarumper
dismissed stale reviews from zaxovaiko and piotrpospiech
via
b12ab33
ErnestTeluk
approved these changes
Feb 28, 2024
Monteth
approved these changes
Mar 8, 2024
|
|
||
| if (options.testShowInlineError) { | ||
| test('<TextField> - renders a TextField with correct error text (specified)', () => { | ||
| const errorMessage = 'Error'; |
There was a problem hiding this comment.
I'd put a different errorMessage text to not interfere with a probable default text. Something like "Error message test" would be nice.
zendranm
approved these changes
Mar 28, 2024
zaxovaiko
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is part of #1130